Fix issue 1255 - #1372
Conversation
…t Archive query fails
|
Have you tested to see if this works as intended if a user does not supply an inits.json file? |
Hi Dr. Zellem , I have performed a regression test on the interactive (non-JSON) workflow to verify the fix. |
|
Executed review, 2026-08-22 (part of the open-PR triage Rob asked me to run; evidence only, decisions stay with maintainers). What it does: when the NASA Exoplanet Archive query returns no usable coordinates (candidate targets, omissions, API failures), falls back to the inits.json RA/DEC so the FOV plot can still be generated (issue #1255). Static assessment: the direction is right and the issue is real. Three things before merge:
Recommendation: iterate (answer 1, clean 2), and run the scenario on #1373 — if the magic branch already handles it, close as superseded with the issue cross-referenced; if not, this is a reasonable develop-side stopgap. |
This PR resolves Issue #1255 by implementing a coordinate-based fallback for the Field of View (FOV) plot.
The Problem:
When the NASAExoplanetArchive query fails (due to target omission, candidate status, or API instability), the pipeline currently fails to generate the FOV plot because of missing coordinates in pDict.
The Solution:
I have implemented a logic bridge in exotic/exotic.py that checks for user-provided RA and DEC values in userpDict (from inits.json) if the NASA Archive lookup returns empty.
Safety Features:
Utilizes .get() for safe dictionary access.
Includes a secondary check to prevent NoneType crashes if both the Archive and the user-input are missing.
Added logging to notify the user when a fallback is active.
Testing:
Verified syntax via py_compile.
Passed all 45 existing unit tests (test_ld.py and test_utils.py) using pytest on Python 3.12.
Resolves #1255